Report a message the SMTP server rejects (1.0.4) #5

Merged

joeyr merged 1 commit from fix/smtp-data-reply into main

2026-10-05 20:08:57 -05:00

joeyr commented

2026-10-05 20:06:50 -05:00

Owner

A message the mail server rejected was still logged as sent.

The server judges a message only after its final ".", so a rejection (spam filter, size limit, policy) is the reply to closing DATA. sendEmail deferred wc.Close() and dropped that error. Close is now checked, and a rejection logs "Failed to send email to …" with the server's reply.

smtp/sender.go: check the write and the end-of-DATA reply.
smtp/sender_session_test.go: the fake server's end-of-DATA reply is a parameter. The new test answers 554, and it fails on the old code.
CLAUDE.md: the planned-work list now has the order and decisions agreed on 2026-10-05.
VERSION 1.0.4, CHANGELOG.

🤖 Generated with Claude Code

A message the mail server rejected was still logged as sent. The server judges a message only after its final ".", so a rejection (spam filter, size limit, policy) is the reply to closing DATA. `sendEmail` deferred `wc.Close()` and dropped that error. Close is now checked, and a rejection logs "Failed to send email to …" with the server's reply. - `smtp/sender.go`: check the write and the end-of-DATA reply. - `smtp/sender_session_test.go`: the fake server's end-of-DATA reply is a parameter. The new test answers 554, and it fails on the old code. - `CLAUDE.md`: the planned-work list now has the order and decisions agreed on 2026-10-05. - VERSION 1.0.4, CHANGELOG. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

joeyr added 1 commit

2026-10-05 20:06:50 -05:00

Report a message the SMTP server rejects (1.0.4)

CI / gate (pull_request) Successful in 59s

Details

CI / lint (pull_request) Successful in 55s

Details

CI / image (pull_request) Has been skipped

Details

7c10620fb9

A server judges a message only after its final ".", and that verdict
(spam filter, size limit, policy) is the reply to closing DATA. sendEmail
deferred wc.Close() and dropped its error, so a refused newsletter still
logged "Successfully sent". Close is now checked, and a rejection logs
"Failed to send email to ..." with the server's reply, e.g. 554.

The fake SMTP server in the session test now takes its end-of-DATA
reply as a parameter; the new test has it answer 554 and fails on the
old code, which logged the message as sent.

CLAUDE.md's planned-work list is replaced by the order and decisions
agreed on 2026-10-05.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

joeyr merged commit 9474595f5b into main

2026-10-05 20:08:57 -05:00

joeyr deleted branch fix/smtp-data-reply

2026-10-05 20:08:57 -05:00

joeyr referenced this pull request from a commit

2026-10-05 20:08:58 -05:00

Release 1.0.4: report a message the SMTP server rejects (#5)